(Pt.2) Minor suggestion: New splash screen#12
Open
LiquidRekto wants to merge 2 commits intoGabeJWJ:masterfrom
Open
(Pt.2) Minor suggestion: New splash screen#12LiquidRekto wants to merge 2 commits intoGabeJWJ:masterfrom
LiquidRekto wants to merge 2 commits intoGabeJWJ:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuation from #7
There are currently two choices that I'm not sure whether to pick about:
Option 1: Use only logo (with transparent background)
This is the approach that the default Godot splash screen uses, ensuring no black bars in the sides, I can even make a gradient background.
However, on the desktop version, solid background color is the only choice, which is bland and boring, and you obviously didn't like it.
Option 2 (CURRENTLY THE LATEST COMMIT): Use background image
This version looks consistent across both desktop and web platforms.
However, there's a caveat on the web: depending on the screen size, you might see black bars either horizontally or vertically. Unfortunately, you can't directly change their color in the web export. (See this issue). To mitigate this, I've added the following to the HTML Head Include:
(Based on this workaround)
Both options all have this Head Include for the web export
What is the better option in your opinion?