Add API to group items together for the smeltery in NEI#278
Open
tiffit wants to merge 6 commits intoGTNewHorizons:masterfrom
Open
Add API to group items together for the smeltery in NEI#278tiffit wants to merge 6 commits intoGTNewHorizons:masterfrom
tiffit wants to merge 6 commits intoGTNewHorizons:masterfrom
Conversation
Guvante
reviewed
Apr 29, 2026
| private int nextSmeltingGroupIndex = 0; | ||
| private final Map<String, Integer> smeltingGroupIndexList = new HashMap<>(); | ||
| private final Map<ItemMetaWrapper, Integer> smeltingGroupIdList = new HashMap<>(); | ||
| private final Map<Integer, List<ItemMetaWrapper>> smeltingGroupList = new HashMap<>(); |
There was a problem hiding this comment.
I have seen a lot of specialized types used when working with int to avoid boxing the integer but don't know if that is important here (and similarly elsewhere where Set<Integer> is used)
Author
There was a problem hiding this comment.
I dont think it will hurt. I moved all the maps and sets over to a fastutils impl
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Items can now be assigned a "smelting group." Items in the same smelting group will show up as a single recipe in NEI.
Smelting groups are meant to be as backwards-compatible as possible. It is an extra layer put on top rather than changing the existing smelting recipe format.
Smelting groups are stored as integers internally to improve lookup speed and reduce memory usage.
In GTNH, each ore has multiple stone types and each of these has its own recipe in NEI. With this, we can combine all "iron ore" for example into a single recipe to de-clutter the category.