Refactor brownstone player speed calculation#272
Open
Kiryu144 wants to merge 2 commits intoGTNewHorizons:masterfrom
Open
Refactor brownstone player speed calculation#272Kiryu144 wants to merge 2 commits intoGTNewHorizons:masterfrom
Kiryu144 wants to merge 2 commits intoGTNewHorizons:masterfrom
Conversation
Member
|
@Kiryu144 thanks for your contribution but build it against master branch. Dev is a temp branch. Thanks |
Author
Got it. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old implementation caused lots of jittering. And instead of spending the time to get to GT Concrete, I'll rather spend the time on this PR to fix it.
I've tried removing the existing
< 0.5Dchecks, with no improvement.So I literally just copied the code from GT.
Balancing wise I believe its a bit faster than it was before. Its hard to say, as the values don't translate correctly into the new logic. GT concrete gives a
40%increase. I've opted to give the brownstone roads30%and all other brownstone variants get15%.I have no idea what I'm doing so please double check.