Skip to content

Much faster recipe dumper#920

Merged
slprime merged 5 commits intomasterfrom
optimize-recipe-id-command
Apr 25, 2026
Merged

Much faster recipe dumper#920
slprime merged 5 commits intomasterfrom
optimize-recipe-id-command

Conversation

@danyadev
Copy link
Copy Markdown
Member

@danyadev danyadev commented Apr 23, 2026

  • it takes 2:30 1:20 mins instead of 1 hour
  • the dump has a size of 100mb instead of 400mb, such difference is because the initial dumper had a lot of duplicates, and the new dumper also lacks many gendustry / genetics autogenerated recipes

All GregTech recipes are pretty much kept

I kept both dumpers in case the initial dumper is still useful

Initial dumper spent 100% of its time on handler.getRecipeHandler for every item in mc
image

New dumper spends most of its time on ItemInfo.isHidden -> ... -> String.toLowerCase when writing recipes
image

Perhaps we can parallelize these calls to make it even faster?

Yes! There's a few really large handlers like shaped / shapeless recipes so we were stuck on them, but now we're processing other handlers while stuck so we've cut another 50% or 1 minute:
image

@Dream-Master Dream-Master requested a review from slprime April 24, 2026 20:28
@slprime slprime merged commit f8cec9a into master Apr 25, 2026
1 check passed
@slprime slprime deleted the optimize-recipe-id-command branch April 25, 2026 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants