Add File Bucket And Provider routes

[llam36]

Add File Bucket And Provider routes

[greptile-apps]

Disclaimer: This comment was AI-generated and is not necessarily completely accurate. Please take code comments with a grain of salt.

Greptile Summary

• Added CRUD endpoints for file buckets and providers across api-gateway, db-service, and file-service layers
• Refactored S3/Azure handlers to separate provider operations from database operations for better separation of concerns
• Introduced getAllProviders and getBucketsByConfigIdAndEnv endpoints to support querying operations

Confidence Score: 2/5

• PR has critical bugs that will cause runtime failures and prevent proper error handling
• Three critical issues found: missing await keywords on async handler calls will prevent error handling, incorrect TypeScript return type syntax, and route ordering conflict that will break the GET all providers endpoint
• Pay close attention to packages/file-service/src/modules/file_bucket/file_bucket.service.ts and packages/api-gateway/src/modules/file_provider/file_provider.controller.ts

Important Files Changed

Filename	Overview
packages/file-service/src/modules/file_bucket/file_bucket.service.ts	Refactored bucket registration/deletion logic but missing critical await keywords on async handler calls
packages/db-service/src/modules/file_bucket/file_bucket.service.ts	Added getBucketsByConfigIdAndEnv method with incorrect return type syntax on getBucket method
packages/api-gateway/src/modules/file_provider/file_provider.controller.ts	Added delete and getAll endpoints but route ordering issue will cause /provider/all to match DELETE route

Sequence Diagram

sequenceDiagram
    participant User
    participant APIGateway as "API Gateway"
    participant FileService as "File Service"
    participant DBService as "DB Service"
    participant Provider as "S3/Azure Provider"
    
    User->>APIGateway: "POST /file/bucket"
    APIGateway->>FileService: "registerBucket()"
    FileService->>DBService: "getProvider()"
    DBService-->>FileService: "provider details"
    FileService->>Provider: "createBucket()"
    Provider-->>FileService: "bucket created"
    FileService->>DBService: "createBucket()"
    DBService-->>FileService: "bucket saved"
    FileService-->>APIGateway: "bucket data"
    APIGateway-->>User: "FileBucket response"

Loading

[greptile-apps]

Additional Comments (1)

1. packages/db-service/src/modules/file_bucket/file_bucket.service.ts, line 10 (link)

   syntax: Return type syntax incorrect - | null should be part of Promise generic

_{19 files reviewed, 4 comments}

_{Edit Code Review Agent Settings | Greptile
React with 👍 or 👎 to share your feedback on this new summary format}