-
Notifications
You must be signed in to change notification settings - Fork 0
upgrade nextjs, npm, & node versions #177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
❌ Deploy Preview for bog-ican failed. Why did it fail? →
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Disclaimer: This comment was AI-generated and is not necessarily completely accurate. Please take code comments with a grain of salt.
Greptile Overview
Greptile Summary
This PR upgrades the application from Next.js 15.2.4 to 16.0.1 and Node.js 18 to 24, updating all related configuration files and dependencies.
Key changes:
- Node.js upgraded from 18 to 24 across
.nvmrc,Dockerfile, andpackage.jsonengine requirements - Next.js upgraded from 15.2.4 to 16.0.1 with associated dependency updates
- TypeScript config updated:
jsxchanged frompreservetoreact-jsx, and.next/dev/types/**/*.tsadded to includes - One API route refactored to follow a better pattern for handling async params (resolve once, extract properties)
Potential concerns:
- Only one API route file was updated with the improved params handling pattern, but 16+ other route files still use the less efficient
(await params).propertyNamepattern throughout the codebase - The PR is marked as "wip" (work in progress), suggesting it may be incomplete
- No test execution results or build verification included to confirm the upgrade works correctly
Confidence Score: 3/5
- This PR has structural consistency but appears incomplete and lacks verification
- The major version upgrades (Next.js 15→16, Node 18→24) are correctly implemented across configuration files. However, the PR is marked "wip", only one route file was refactored while 16+ others remain unmodified with the old pattern, and there's no evidence of build/test verification. The inconsistent refactoring suggests incomplete work.
- Check that all 16+ API route files in
src/app/api/v1/use consistent params handling patterns. Verify build succeeds and all tests pass with the new Next.js and Node versions.
Important Files Changed
File Analysis
| Filename | Score | Overview |
|---|---|---|
| package.json | 4/5 | Upgraded Next.js from 15.2.4 to 16.0.1, Node from ^18.20.0 to >=24.0.0, npm requirement from ^10.0.0 to >=10.0.0, and various dependencies including Zod and eslint-config-next |
| tsconfig.json | 5/5 | Changed jsx from 'preserve' to 'react-jsx' and added .next/dev/types/**/*.ts to includes - formatting changes for readability |
| src/app/api/v1/pet/[petId]/outfit/[name]/route.ts | 4/5 | Refactored to resolve params once and extract properties, instead of awaiting params multiple times - improves code efficiency |
Sequence Diagram
sequenceDiagram
participant Dev as Developer
participant NVM as .nvmrc
participant Docker as Dockerfile
participant NPM as package.json
participant Lock as package-lock.json
participant TS as tsconfig.json
participant API as API Routes
Dev->>NVM: Update Node version 18→24
Dev->>Docker: Update base image node:18→node:24
Dev->>NPM: Upgrade Next.js 15.2.4→16.0.1
Dev->>NPM: Update Node engine requirement >=24.0.0
Dev->>NPM: Update @types/node to ^24
NPM->>Lock: Resolve dependencies
Lock->>Lock: Install Next.js 16 + transitive deps
Lock->>Lock: Add Babel core packages
Lock->>Lock: Update sharp, eslint packages
Dev->>TS: Change jsx: preserve→react-jsx
Dev->>TS: Add .next/dev/types to includes
Dev->>API: Refactor params handling pattern
API->>API: Await params once, extract properties
5 files reviewed, 1 comment
|
waiting on a new version of juno-sdk to fix the version issues we're having rn |
PR Title
Issue Number(s): #176
What does this PR change and why?
Checklist
Critical Changes
Related PRs
Testing
Enumerate steps to test the functionality of your ticket. This should include edge cases and testing of error handling, if applicable.