Skip to content

remove email check #1911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 12, 2025
Merged

remove email check #1911

merged 6 commits into from
Aug 12, 2025

Conversation

terrazoon
Copy link
Contributor

@terrazoon terrazoon commented Aug 12, 2025

Description

We implemented login.gov about a year ago. When working with login.gov the best practice is the use the login.gov user UUID as the source of truth for who the user is. However, we had to transition users off our old legacy login system and didn't know when they would all be fully transitioned. So we implemented a back up check that said "if we don't have user UUID in our database, but we do have the user email, assume it's the same user and write the UUID to that entry in the database for future use."

That transition should be complete now, so remove the email backup check.

Security Considerations

N/A

Copy link
Contributor

@ccostino ccostino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @terrazoon!

@ccostino ccostino merged commit 366c9f5 into main Aug 12, 2025
7 checks passed
@ccostino ccostino deleted the email_check branch August 12, 2025 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants