Skip to content

Add ADR 0015 (improving report generation) and update ADR listing #1906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 12, 2025

Conversation

ccostino
Copy link
Contributor

A note to PR reviewers: it may be helpful to review our code review documentation to know what to keep in mind while reviewing pull requests.

Description

This changeset adds a new ADR, 0015 (Improve API stability when processing job data and generating reports), and updates the ADR log in the ADR README.

Security Considerations

  • None; this is all public documentation.

This changeset adds a new ADR, 0015 (Improve API stability when processing job data and generating reports), and updates the ADR log in the ADR README.

Signed-off-by: Carlo Costino <[email protected]>
@terrazoon
Copy link
Contributor

@ccostino we are still using the jobs_cache, however we ultimately moved to just using a plain python dictionary. With the recent fix involving the race condition with updating the cache, it is now performant and working the way we always hoped it would:

  1. jobs_cache is regenerated at app startup and refreshed every 30 minutes
  2. report generation will make use of the cache for phone numbers and personalization. Right now 1000 row reports are generating in 2-4 seconds.
  3. reports are stored in the bucket for a max of seven days.

@ccostino
Copy link
Contributor Author

Thanks, @terrazoon! I'll work in updates to the documentation to reflect that!

Copy link
Contributor

@heyitsmebev heyitsmebev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @terrazoon for pointing these items out!

Signed-off-by: Carlo Costino <[email protected]>
@ccostino ccostino merged commit eddf00b into main Aug 12, 2025
7 checks passed
@ccostino ccostino deleted the add-report-generation-adr branch August 12, 2025 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ADR documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants