Conversation
After update to PHP7.4 but before change to ORM2.6.
Moving to PHP7.4 generates some Notice reports from the Doctrine code which cause tests to fail. This can be switched back on for later ORM versions where this is fixed.
As of PHP 7.2.0 count() yields a warning on invalid countable types passed to the value parameter.
Removes various unit test errors.
Moving to PHP7.4 generated Notice reports during phpunit tests for ORM 2.5.14. This re-enables the reports which were temporarily switched off to allow the tests to run.
As of ORM 2.10 Doctrine annotations require an exta package called doctrine/annotations (requires symfony/cache). https://www.doctrine-project.org/projects/doctrine-orm/en/2.10/reference/annotations-reference.html and https://github.com/doctrine/orm/blob/2.10.x/UPGRADE.md#upgrade-to-29
There was a problem hiding this comment.
The changes in every file other than composer.lock are the same as in PR #344.
There is a difference of about 300 additions/deletions between the changes made to composer.lock in this PR and #344, with more changes being made to #344.
There are a couple more lines changed to composer.json in #344 than this PR - I think this is due to updates in other PRs made between these two PRs, and not a problem.
Apart from that, the other files are the same.
I assume the first reference to #357 should be #344 ? Thanks again for this, RE: composer.json - yes, the difference seems to be because 4dad3cd has already been merged. As mentioned in #454, composer.lock needs regenerating anyway before merging - so if that's the only hard to explain difference I am happy with that 😋 |
yep i've updated it to #344. |
2 participants
Replaces closed #344 as fork has been deleted.
Depends on #454
Closes #335