Add processing and comparison of ctests in JEDI builds#778
Open
Add processing and comparison of ctests in JEDI builds#778
Conversation
Contributor
|
@mranst, Can you please add documentation for this new feature? |
mer-a-o
reviewed
May 8, 2026
| width_col_2 = max(len('Fail'), len(experiment_tag_2)) + 2 | ||
|
|
||
| for bundle in bundles: | ||
| max_width = max(len(bundle), max([results_dict[bundle][test]['width'] |
Contributor
There was a problem hiding this comment.
What will happen here if all ctests pass for both experiments?
Collaborator
Author
There was a problem hiding this comment.
There wouldn't be any tests listed, I've added a line specifying all tests pass. If all tests fail for both, this task would pass, I rely on the user to ensure that the control build is acceptable
mer-a-o
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Addressing #699 and #442, this PR adds tasks to run ctests for selected bundles within JEDI, and compare the number passed between two builds. I'm envisioning this being a part of tier2 tests by running ctests for fv3-jedi whevever JEDI is built nightly, then confirming the same tests pass as the previous pinned version (For fv3-jedi, at least, there's always some that fail). It's currently geared to run for fv3-jedi, but can theoretically work for any JEDI bundle
Output of CompareJediCtests looks like this: