Add OMIEFF

[rtodling]

Description

This is done for consistency w/ more recent versions of GEOS which from a certain data onward replace OMI_AURA w/ OMIEFF_AURA - the two datasets are similar but different versions with the more recent version being given a GMAO-centric name.

Dependencies

• waiting on GEOS-ESM/repo/pull/<pr_number>

Impact

None

[kwargan]

Looks good to me. Does the observation operator actually assimilate OMIEFF using apriori and averaging kernels like in the GSI?

[jeromebarre]

I am sorry Ricardo but as as you might recall the AtmVertInterpLay is obsolete (no one else is now using it) and possibly has issues. JCSDA might be planning to phase it out. I recommend using ColumnRetrieval instead.

[jeromebarre]

Looks good to me. Does the observation operator actually assimilate OMIEFF using apriori and averaging kernels like in the GSI?

No unfortunately I don't think AtmVertInterpLay can do that but ColumnRetrieval can ... one more reason to switch operators.

https://github.com/JCSDA-internal/ufo/blob/a13a70e42456aff220b2b49d217984d28e49f5cc/src/ufo/operators/columnretrieval/ObsColumnRetrievalParameters.h#L37

https://github.com/JCSDA-internal/ufo/blob/a13a70e42456aff220b2b49d217984d28e49f5cc/src/ufo/operators/columnretrieval/ObsColumnRetrievalParameters.h#L42

[jeromebarre]

Given recent discussions with Ricardo, Kris and in a matter of documenting this when it is time to revisit:

We agreed that the AtmVertInterpLay should be maintained for the current T2O effort on FP. ColumnRetrieval will be used in the CF configuration using the same dataset possibly and then transitioned to FP over the years.

Keep in mind that AtmVertInterpLay, despite similarity in coding style, is not equivalent to what is in GSI currently especially regarding the efficiency/averaging kernels factors and apriori... so we shouldn't expect a match between GSI and JEDI using this operator. NOAA/EMC also reported TL/AD issues but this has to be proven than just said... the possible degradation in O3 analysis needs to be carefully adressed then. I am happy to help if needed.

Vertical column integration routines below
GSI intoz:
https://github.com/GEOS-ESM/GEOSana_GridComp/blob/develop/GEOSaana_GridComp/GSI_GridComp/intoz.f90

JEDI AtmVertInterpLay:
https://github.com/JCSDA/ufo/blob/develop/src/ufo/operators/atmvertinterplay/vert_interp_lay_mod.F90

JEDI ColumnRetrieval:
https://github.com/JCSDA/ufo/blob/develop/src/ufo/operators/columnretrieval/ufo_satcolumn_mod.F90