Skip to content

GETKF calculation in two steps#692

Open
metdyn wants to merge 8 commits intodevelopfrom
feature/ygyu/pr_getkf_2steps
Open

GETKF calculation in two steps#692
metdyn wants to merge 8 commits intodevelopfrom
feature/ygyu/pr_getkf_2steps

Conversation

@metdyn
Copy link
Copy Markdown
Contributor

@metdyn metdyn commented Jan 30, 2026

Description

This PR sets up a two-step calculation to compute analysis from GETKF with linear observer. The GETKF code can run on 4 Milan nodes with 32 ensemble members at C90 resolution when 30 obs files are each thinned by 75%. Aircraft_temperature and wind obs are commented out, because there are unknown jedi source code issues that goes out of the scope this PR.

  • Variational bc is used and reading JEDI source code shows why this works in two steps calculations.

Dependencies

Impact

@metdyn
Copy link
Copy Markdown
Contributor Author

metdyn commented Feb 2, 2026

I am still working on node assignment for executable runs from this PR.

@metdyn
Copy link
Copy Markdown
Contributor Author

metdyn commented Feb 9, 2026

Temporarily withhold this code change to add more improvements.

@metdyn metdyn closed this Feb 9, 2026
@metdyn
Copy link
Copy Markdown
Contributor Author

metdyn commented Mar 9, 2026

I have been inspecting the input and output from the ensemble runs when this PR was initially created and closed. Now I donot see problems with this infrastructure complement. Hence I will have a few other PRs related to local ensemble DA intended to merge into this base PR.

@metdyn metdyn reopened this Mar 9, 2026
@metdyn metdyn changed the title GETKF calculation in two steps GETKF calculation in two steps (base, merge last) Mar 9, 2026
@metdyn metdyn changed the title GETKF calculation in two steps (base, merge last) GETKF calculation in two steps Mar 23, 2026
@metdyn
Copy link
Copy Markdown
Contributor Author

metdyn commented Mar 23, 2026

Hi all,

I want people to review this PR. It is technical and affect local ensemble solver only. I want to get this PR and a few other GETKF related PR merged to develop, so that we can test the scientific part of the algorithm related to JEDI code. Currently @rtodling and me are having problems with the output from local ensemble solver, and I am not concerned with the swell implementation here.

@mranst mentioned the T2 test failed and I think this is related to the ongoing UKMO work on UFO code

I modified the yaml input for GETKF to include only sondes, sfcship, atms_n20 and this should make the GETKF tier1 and tier2 test run without error.

Copy link
Copy Markdown
Collaborator

@mranst mranst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a limited understanding of the technical aspects of this PR, but from my perspective it looks good. Tier 1 tests ran without issue.

@mo-owenaljabar
Copy link
Copy Markdown

@mranst mentioned the T2 test failed and I think this is related to the ongoing UKMO work on UFO code

@metdyn @mranst what's the configuration that's giving the failure? The amount of time for localisation to be implemented depends on which correlated R class you're trying to use, as we're treating the different classes one by one. Work on cross variable covariances is currently underway, but within group covariances and the new diffusion based R matrix are further off.

@mranst
Copy link
Copy Markdown
Collaborator

mranst commented Apr 2, 2026

@mranst mentioned the T2 test failed and I think this is related to the ongoing UKMO work on UFO code

@metdyn @mranst what's the configuration that's giving the failure? The amount of time for localisation to be implemented depends on which correlated R class you're trying to use, as we're treating the different classes one by one. Work on cross variable covariances is currently underway, but within group covariances and the new diffusion based R matrix are further off.

Tier tests are not currently failing due to localensembleda. I tested the suite against today's build of JEDI and it executed correctly, as far as I could tell.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants