Add MAPL_StateMerge to state library#5199
Merged
Merged
Conversation
weiyuan-jiang
added
0 Diff
added 2 commits
June 26, 2026 13:14
ESMF_StateItem_Flag is an opaque derived type with no pFUnit assertEqual overload. Switch to assertTrue with == comparison.
tclune
reviewed
Jul 1, 2026
tclune
reviewed
Jul 1, 2026
tclune
reviewed
Jul 1, 2026
tclune
left a comment
tclune
left a comment
Collaborator
There was a problem hiding this comment.
I put in some suggestions, but I don't want to obligate you to make those changes. If you want to delay those fixes to a subsequent pass, I can go in and approve for now.
tclune
previously approved these changes
Jul 2, 2026
tclune
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types of change(s)
Checklist
make tests)Description
Related Issue