Remove MAPL_GenGridName from Base (#4835)#4836
Merged
Merged
Conversation
tclune
added
0 Diff
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes
MAPL_GenGridNamefromMAPL_Baseas part of the ongoing MAPL v3 Base cleanup.Base_Base.F90Base_Base_implementation.F90Closes #4835
Notes
The only caller in GEOSgcm is
c2c_rst.F90, which usedMAPL_GenGridNamesolely to construct a tile file name forMAPL_HorzTransformCreate— a function that has already been removed from MAPL entirely.c2c_rst.F90is therefore already broken at a more fundamental level and requires a full rewrite against the MAPL v3 regridding infrastructure. There are no other callers anywhere in GEOSgcm.