Delete MAPL_Config.F90 and time_ave_util.F90#4786
Open
tclune wants to merge 2 commits intorelease/MAPL-v3from
Open
Delete MAPL_Config.F90 and time_ave_util.F90#4786tclune wants to merge 2 commits intorelease/MAPL-v3from
tclune wants to merge 2 commits intorelease/MAPL-v3from
Conversation
- Delete base/MAPL_Config.F90 (MAPL_ConfigMod); superseded by HConfig in MAPL3 - Delete Apps/time_ave_util.F90 (disabled in build; functionality covered by GEOS_Util/time_avg.F) - Delete base/tests/Test_MAPL_Config.pf and remove from base/tests/CMakeLists.txt - Remove use MAPL_ConfigMod from base/Base.F90 - Remove MAPL_Config.F90 from base/CMakeLists.txt - Remove commented-out time_ave_util.x entries from Apps/CMakeLists.txt Closes #4776.
tclune
added
📈 MAPL3
mathomp4
previously approved these changes
May 6, 2026
bena-nasa
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4785
Closes #4776
Changes
Deleted
base/MAPL_Config.F90(MAPL_ConfigMod) — MAPL2-eraESMF_Configwrapper, superseded by HConfig in MAPL3. Remaining callers (GEOS_GcmGridComp,GEOS_AgcmGridComp,GEOS_ChemGridComp,Aerosol_GridComp) are all currently commented out of their builds pending MAPL3 porting; they will migrate to HConfig at that time.Apps/time_ave_util.F90— standalone program that was already disabled in the build; functionality is covered bytime_avg.Fin@GEOS_Util.base/tests/Test_MAPL_Config.pf— unit test for the deleted module.Modified
base/Base.F90— removeduse MAPL_ConfigModbase/CMakeLists.txt— removedMAPL_Config.F90from srcsbase/tests/CMakeLists.txt— removedTest_MAPL_Config.pffrom test srcsApps/CMakeLists.txt— removed commented-outtime_ave_util.xbuild entries