Skip to content

Add river routing#850

Merged
gmao-rreichle merged 13 commits intodevelopfrom
feature/rreichle/route
May 7, 2026
Merged

Add river routing#850
gmao-rreichle merged 13 commits intodevelopfrom
feature/rreichle/route

Conversation

@gmao-rreichle
Copy link
Copy Markdown
Contributor

@gmao-rreichle gmao-rreichle commented Dec 3, 2025

Related PRs:
GEOS-ESM/GEOSldas_GridComp#145 (merged)
GEOS-ESM/GEOSgcm_GridComp#1143 (merged)
GEOS-ESM/GEOSgcm_GridComp#1375 (merged)
GEOS-ESM/MAPL#4000 (merged and captured in MAPL v2.64.0)

Comment thread doc/README.OutputSpecs.md Outdated
@biljanaorescanin
Copy link
Copy Markdown
Contributor

biljanaorescanin commented Apr 10, 2026

@zyj8881357 conflict on PR is still not resolved. Are we using new MAPL or not?

@gmao-rreichle
Copy link
Copy Markdown
Contributor Author

@zyj8881357 conflict on PR is still not resolved. Are we using new MAPL or not?

I merged develop, which fixes this. See also #857

@biljanaorescanin
Copy link
Copy Markdown
Contributor

All tests passed.

Interesting tidbit:
Initially, the globalcs test failed. It turned out I was running tests on discover31, but this test requires running the package on discover36. Since for that test we need MERRA2 meteorological forcing, which leads to a segmentation fault for this case.

@biljanaorescanin biljanaorescanin marked this pull request as ready for review April 10, 2026 17:47
@biljanaorescanin
Copy link
Copy Markdown
Contributor

All tests pass if we use this branch + use GEOS_Util bug fix branch PR215 + GEOSgcm_GridComp PR1375

@gmao-rreichle
Copy link
Copy Markdown
Contributor Author

All tests pass if we use this branch + use GEOS_Util bug fix branch PR215 + GEOSgcm_GridComp PR1375

Thanks, @biljanaorescanin. For clarification, I don't think that the GEOS_Util bug fix branch PR215 is necessary for successful GEOSldas simulations. The GEOS_Util bug fix only touches the remap_restarts test script, which is not used by GEOSldas. That is, we can merge this PR and GEOS-ESM/GEOSldas_GridComp#145 without needing a new GEOS_Util release. We can merge this PR to get the GEOSldas routing functionality and then later update the GEOSldas components.yaml file again once there's a new GEOS_Util release is available that includes GEOS_Util PR #215.

@gmao-rreichle gmao-rreichle merged commit cadfdfc into develop May 7, 2026
8 checks passed
@gmao-rreichle gmao-rreichle deleted the feature/rreichle/route branch May 7, 2026 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-diff enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants