Skip to content

AdvCore: First attempt at porting to MAPL3#366

Merged
tclune merged 1 commit intorelease/MAPL-v3from
feature/pchakrab/port-advcore-to-mapl3
May 5, 2026
Merged

AdvCore: First attempt at porting to MAPL3#366
tclune merged 1 commit intorelease/MAPL-v3from
feature/pchakrab/port-advcore-to-mapl3

Conversation

@pchakraborty
Copy link
Copy Markdown
Collaborator

  • Explicit MAPL3 imports
  • Initialize grid via MAPL_GridCompSetGeometry
  • Better use of ACG generated include files

- Explicit MAPL3 imports
- Initialize grid via MAPL_GridCompSetGeometry
- Better use of ACG generated include files
@pchakraborty pchakraborty self-assigned this May 5, 2026
@pchakraborty pchakraborty requested a review from a team as a code owner May 5, 2026 17:29
@pchakraborty pchakraborty added the 0 diff The changes in this pull request have verified to be zero-diff with the target branch. label May 5, 2026
@pchakraborty pchakraborty requested a review from a team as a code owner May 5, 2026 17:29
@pchakraborty pchakraborty added MAPL3 MAPL 3 Related mapl3-migration Migrate a GridComp to MAPL3 APIs (late phase) labels May 5, 2026
Copy link
Copy Markdown
Collaborator

@tclune tclune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compiles - which is good enough for now.

@tclune tclune merged commit ef85d31 into release/MAPL-v3 May 5, 2026
17 checks passed
@tclune tclune deleted the feature/pchakrab/port-advcore-to-mapl3 branch May 5, 2026 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0 diff The changes in this pull request have verified to be zero-diff with the target branch. mapl3-migration Migrate a GridComp to MAPL3 APIs (late phase) MAPL3 MAPL 3 Related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants