AdvCore: First attempt at porting to MAPL3#366
Merged
tclune merged 1 commit intorelease/MAPL-v3from May 5, 2026
Merged
Conversation
Collaborator
pchakraborty
commented
May 5, 2026
- Explicit MAPL3 imports
- Initialize grid via MAPL_GridCompSetGeometry
- Better use of ACG generated include files
- Explicit MAPL3 imports - Initialize grid via MAPL_GridCompSetGeometry - Better use of ACG generated include files
tclune
approved these changes
May 5, 2026
Collaborator
tclune
left a comment
There was a problem hiding this comment.
Compiles - which is good enough for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.