Porting to MAPL3#361
Merged
pchakraborty merged 9 commits intoMay 4, 2026
Merged
Conversation
…upling - Replace TRADV item type with MAPL service state items and register it as an export-side service payload - Read TRADV from export state - Add and fill PLE4 export (32 bit edge pressure) - Temporarily force replay shutoff path and comment out related alarm/timer while alarm wiring is being stabilized - Temporarily turn off verbose debug max/min logging
…hakrab/port-held-suarez-to-mapl3
Also renamed the config file fv3sa.yaml as dyn-sa.yaml
…lay alarm - Add get_short_name() function to map CF standard names back to MAPL short names (Q, QLLS, QLCN, etc.); replaces direct ESMF_FieldGet(name=...) calls that returned internal MAPL-generated names - Use MAPL_FieldBundleSameData to assert that the import and export TRADV bundles share the same data pointers - Restore ReplayShutOff alarm creation in Initialize and re-enable ESMF_ClockGetAlarm / timer calls in Run and RunAddIncs - For the standalone case, initialize tracer in a separate DataMoist gridcomp, using data-moist.yaml. Remove unused addTracer routines - Remove unused names0 array, and tradvex bundle - Rename freeTracers → free_tracers and normalize argument names in PULL_Q (InFieldName → in_field_name, etc.) - Lowercase all TRIM() intrinsic calls to trim()
…hakrab/port-held-suarez-to-mapl3
pchakraborty
added
0 diff
tclune
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part of porting the Held-Suarez application to MAPL3. Changes include
FVdycoreCubed_GridComp
TRADVcoupling: import FieldBundle → SERVICE exportChanges
TRADVfrom aMAPL_STATEITEM_FIELDBUNDLEimport to aMAPL_STATEITEM_SERVICEexport. The service mechanism places the bundle in both states; the dycore reads from its export state in the run path, avoiding mutation of import-owned data.MAPL_FieldBundleSameDataasserts pointer identity between the two bundle handles as a consistency check, replacing the previousMAPL_FieldBundleCopycall.New:
get_short_name()helperMaps CF standard names (e.g.,
"specific_humidity") to MAPL short names (Q,QLLS, etc.) usingMAPL_FieldGet(field, standard_name=...). Replaces directESMF_FieldGet(name=...)calls which returned internal MAPL-generated names rather than user-visible short names.Replay shutoff alarm: moved to Initialize
ESMF_AlarmCreate(withReplayShutOffring-time) now runs inInitialize. Run andRunAddIncsquery the alarm viaESMF_ClockGetAlarm/ESMF_AlarmIsRinginginstead of the previous unconditionalis_shutoff = .true..Cleanup
freeTracers→free_tracers;addTracer_r4/r8procedures andaddTracerinterface removed (dead code)