Remove legacy MAPL2 regridder-dependent code#356
Merged
tclune merged 3 commits intorelease/MAPL-v3from Apr 24, 2026
Merged
Conversation
Remove all code that depended on the removed MAPL2 regridder stack: - CubeToCubeRegridder, CubeToLatLonRegridder, LatLonToCubeRegridder - CubeGridPrototype (registered old-style prototypes into regridder_manager) - fv_regrid_c2c, fv_regrid_c2c_bin (used AbstractRegridder/new_regridder_manager) - interp_restarts, interp_restarts_bin (depended on fv_regrid_c2c*) - c2c (used AbstractRegridder/regridder_manager) Remove corresponding use/call sites in AdvCore_GridCompMod and DynCore_GridCompMod. Update CMakeLists.txt to remove all deleted sources and executable targets.
tclune
commented
Apr 21, 2026
tclune
added
the
0 diff
pchakraborty
previously approved these changes
Apr 22, 2026
Collaborator
pchakraborty
left a comment
pchakraborty
left a comment
There was a problem hiding this comment.
Looks good to me. The MAPL3 port of DynCore wasn’t doing any regridding.
…(refs #4661) - Replace 'use MAPL2' with explicit MAPL3 module uses - Drop ESMF_Grid args from get_geos_ic/get_geos_cubed_ic; replace with ESMF_Geom - Replace AbstractRegridder with mapl3g Regridder (array overloads from #4669) - Replace new_regridder_manager%make_regridder with get_regridder_manager()%get_regridder(RegridderSpec(...)) - Replace CubedSphereGridFactory/grid_manager with CubedSphereGeomSpec/GeomManager in interp_restarts - Add fv_regrid_c2c.F90 and interp_restarts.x back to CMakeLists.txt
tclune
added a commit
that referenced
this pull request
May 2, 2026
This file was missed when PR #356 removed the legacy MAPL2 regridder-dependent code. It should have been deleted then.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes all code in FVdycoreCubed_GridComp that depended on the legacy MAPL2 regridder stack, which is being removed in the companion MAPL PR (GEOS-ESM/MAPL#4662).
Deleted files
Regridder implementations:
Regridder registration:
Restart interpolation executables and support:
Other changes
Notes
This PR should be merged before GEOS-ESM/MAPL#4662 (the MAPL PR is draft until this lands).