Skip to content

Fix NAG Fortran build on macOS for GEOSldas #541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
weiyuan-jiang wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix NAG Fortran build on macOS for GEOSldas #541

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d272c01
Fix NAG Fortran build on macOS for GEOSldas
weiyuan-jiang May 6, 2026
47ba3c7
change log
weiyuan-jiang May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Changed

- changed NAG_Fortran so that some applications like GEOSldas can be built on MacOS

### Deprecated

## [5.9.0] - 2026-04-13
Expand Down
17 changes: 15 additions & 2 deletions compiler/flags/NAG_Fortran.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ set (FREAL8 "-r8")
set (FINT8 "-i8")
set (PP "-fpp")
set (DUSTY "-dusty")
set (MISMATCH "-wmismatch=QSORTL,QSORTS,MPI_Recv,MPI_Send,MPI_Irecv,MPI_BCast,MPI_Allgather,MPI_Allgatherv,MPI_Allreduce,MPI_Scatterv,MPI_Gatherv,MPI_Sendrecv,MPI_File_write,MPI_File_read,MPI_File_Read_at_all,MPI_File_write_at_all,ESMF_UserCompSetInternalState,ESMF_UserCompGetInternalState")
set (MISMATCH "-wmismatch=QSORTL,QSORTS,MPI_Recv,MPI_Send,MPI_Irecv,MPI_BCast,MPI_Gather,MPI_Allgather,MPI_Allgatherv,MPI_Allreduce,MPI_Scatter,MPI_Scatterv,MPI_Gatherv,MPI_Sendrecv,MPI_Alltoallv,MPI_File_write,MPI_File_read,MPI_File_Read_at_all,MPI_File_write_at_all,ESMF_UserCompSetInternalState,ESMF_UserCompGetInternalState")
set (DISABLE_FIELD_WIDTH_WARNING)
set (CRAY_POINTER "")
set (EXTENDED_SOURCE "-132 -w=x95" )
Expand All @@ -19,13 +19,26 @@ set (QUIET "-quiet")

if (APPLE)
option (ESMF_HAS_ACHAR_BUG "ESMF Compatibility issue" OFF)
# NAG Fortran doesn't understand Apple's -F framework flags
# Tell CMake to use -I for all include directories (including frameworks) for Fortran
set(CMAKE_INCLUDE_FLAG_Fortran "-I")
set(CMAKE_INCLUDE_SYSTEM_FLAG_Fortran "-I")
# Tell CMake not to add framework directories to Fortran implicit includes
set(CMAKE_Fortran_IMPLICIT_LINK_FRAMEWORK_DIRECTORIES "" CACHE STRING "")
endif ()

####################################################

# Common Fortran Flags
# --------------------
set (common_Fortran_flags "${F2018} ${MISMATCH} ${QUIET}")
# On macOS, CMake may add -F framework flags that NAG doesn't understand
# We use -w=uep to suppress the specific unrecognised option error
if (APPLE)
set (IGNORE_UNKNOWN_FLAGS "-w=uep")
else()
set (IGNORE_UNKNOWN_FLAGS "")
endif()
set (common_Fortran_flags "${F2018} ${MISMATCH} ${QUIET} ${IGNORE_UNKNOWN_FLAGS}")
set (common_Fortran_fpe_flags "")

# GEOS Debug
Expand Down
9 changes: 6 additions & 3 deletions external_libraries/FindBaselibs.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,10 +98,13 @@ if (Baselibs_FOUND)

# Changes in Baselibs mean on Darwin we need to capture three
# Framework Libraries needed to link with Curl (so netCDF needs them)
# On macOS, use framework names directly instead of find_library to avoid
# CMake adding framework paths to Fortran compiler flags
if (APPLE)
find_library(FWSystemConfiguration NAMES SystemConfiguration)
find_library(FWCoreFoundation NAMES CoreFoundation)
find_library(FWSecurity NAMES Security)
# Use framework names directly - linker will find them automatically
set(FWSystemConfiguration "-framework SystemConfiguration")
set(FWCoreFoundation "-framework CoreFoundation")
set(FWSecurity "-framework Security")
endif ()

add_definitions(-DHAS_NETCDF4)
Expand Down
Loading