Skip to content

fix: avoid log(0) in ElasticIsotropicPressureDependent #3723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 1, 2025
Merged

fix: avoid log(0) in ElasticIsotropicPressureDependent #3723

merged 6 commits into from
Aug 1, 2025

Conversation

paveltomin
Copy link
Contributor

@paveltomin paveltomin commented Jul 9, 2025 •
edited
Loading

also enable ModifiedCamClay model for SolidMechanicsFixedStressThermoPoromechanicsKernels

@paveltomin paveltomin changed the title Pt/avoid log 0 fix: avoid log(0) in ElasticIsotropicPressureDependent Aug 1, 2025
@paveltomin paveltomin self-assigned this Aug 1, 2025
@paveltomin paveltomin added type: bug Something isn't working flag: ready for review ci: run integrated tests Allows to run the integrated tests in GEOS CI labels Aug 1, 2025
@paveltomin paveltomin marked this pull request as ready for review August 1, 2025 18:38
@paveltomin paveltomin added ci: run CUDA builds Allows to triggers (costly) CUDA jobs and removed flag: ready for review labels Aug 1, 2025
jhuang2601
jhuang2601 approved these changes Aug 1, 2025
View reviewed changes
Copy link
Contributor

@jhuang2601 jhuang2601 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix.

@paveltomin paveltomin added the flag: no rebaseline Does not require rebaseline label Aug 1, 2025
@paveltomin paveltomin merged commit 84ea186 into develop Aug 1, 2025
41 of 50 checks passed
@paveltomin paveltomin deleted the pt/avoid-log-0 branch August 1, 2025 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@castelletto1 castelletto1 castelletto1 approved these changes

@jhuang2601 jhuang2601 jhuang2601 approved these changes

@rrsettgast rrsettgast Awaiting requested review from rrsettgast rrsettgast is a code owner

@CusiniM CusiniM Awaiting requested review from CusiniM CusiniM is a code owner

@Guotong-Ren Guotong-Ren Awaiting requested review from Guotong-Ren Guotong-Ren is a code owner

Assignees

@paveltomin paveltomin

Labels
ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI flag: no rebaseline Does not require rebaseline type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paveltomin @castelletto1 @jhuang2601