fix: reporting invalid input of mechanical properties #3717
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhuang2601
requested review from
rrsettgast,
CusiniM,
paveltomin,
castelletto1 and
Guotong-Ren
as code owners
jhuang2601
added
type: bug
castelletto1
approved these changes
Jun 27, 2025
There was a problem hiding this comment.
There should be a more stringent lower bound on Biot's coefficient based on porosity. Regardless, the check introduced here is needed. Thanks @jhuang2601 !
paveltomin
approved these changes
Jul 2, 2025
|
@jhuang2601 is this ready to go? |
herve-gross
approved these changes
Aug 13, 2025
jhuang2601
added
ci: run CUDA builds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Biot coefficient should be in the range of
[0,1]; therefore, the condition0<K<=Ksshould be enforced.Following #3050, PR adds necessary checks and error reporting for any values that fall outside this range.