Skip to content

feat: Add enthalpy to PVT Driver output #3704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

feat: Add enthalpy to PVT Driver output #3704

wants to merge 6 commits into from

Conversation

dkachuma
Copy link
Contributor

Adds the enthalpy to the output of the PVTDriver if the fluid is thermal.

@dkachuma dkachuma self-assigned this Jun 13, 2025
@dkachuma dkachuma added ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI flag: no rebaseline Does not require rebaseline ci: run code coverage enables running of the code coverage CI jobs labels Jun 13, 2025
@dkachuma dkachuma marked this pull request as ready for review June 13, 2025 15:15
@codecov Codecov
Copy link

codecov bot commented Jun 13, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 71.42857% with 6 lines in your changes missing coverage. Please review.

Please upload report for BASE (develop@b05541b). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...constitutiveDrivers/fluid/multiFluid/PVTDriver.cpp 40.00% 6 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             develop    #3704   +/-   ##
==========================================
  Coverage           ?   57.96%           
==========================================
  Files              ?     1250           
  Lines              ?   107564           
  Branches           ?        0           
==========================================
  Hits               ?    62352           
  Misses             ?    45212           
  Partials           ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dkachuma dkachuma requested a review from MelReyCG June 24, 2025 18:19
corbett5
corbett5 approved these changes Jun 24, 2025
View reviewed changes
Copy link
Contributor

@corbett5 corbett5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not much for me to review here, but looks fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corbett5 corbett5 corbett5 approved these changes

@jhuang2601 jhuang2601 jhuang2601 approved these changes

@MelReyCG MelReyCG MelReyCG approved these changes

@rrsettgast rrsettgast Awaiting requested review from rrsettgast rrsettgast is a code owner

@CusiniM CusiniM Awaiting requested review from CusiniM CusiniM is a code owner

@wrtobin wrtobin Awaiting requested review from wrtobin wrtobin is a code owner

Assignees

@dkachuma dkachuma

Labels
ci: run code coverage enables running of the code coverage CI jobs ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI flag: no rebaseline Does not require rebaseline
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dkachuma @corbett5 @jhuang2601 @MelReyCG