ci: Fix pre-commit language - #340
Open
Leonardo-Ma wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements:
Related issue (if applicable): #
What kind of change does this PR introduce?
Pre-commit.yaml now uses supported rust language instead of "unsupported", so pre-commit now correctly installs the formatter. So it's no longer necessary to manually install and configure the tool and PATH. (Part of pre-commit's objective in first place).
Does this PR introduce a breaking change?
Yes, but unlikely. If not properly installed or configured, but has the pre-commit file, it will execute the formatter on staged files upon commit.
Other information
The note in Formatting automatically on commit is no longer needed (no longer needs formatter installed).
The linter, however, doesn't work for me in either cases. But that's unrelated to these changes.