refactor(stream): unify indexed tool-call accumulation across adapters#437
Merged
GCWing merged 1 commit intoGCWing:mainfrom Apr 17, 2026
Merged
refactor(stream): unify indexed tool-call accumulation across adapters#437GCWing merged 1 commit intoGCWing:mainfrom
GCWing merged 1 commit intoGCWing:mainfrom
Conversation
Collaborator
wsp1911
commented
Apr 17, 2026
wsp1911
commented
- preserve provider tool-call indices in unified stream types and route interleaved tool deltas by index
- move tool-call buffering/finalization into the shared accumulator and remove OpenAI-specific orphan/prelude filtering
- update stream processor and response aggregators to consume accumulator outcomes for early detection and param streaming
- ignore empty tool argument deltas and keep fallback handling for snapshot/tail-fill edge cases
- add OpenAI stream regression fixtures for interleaved args, missing tool type, and trailing empty finish chunks
- document that changes to stream processor or ai-adapters must run stream integration tests
- preserve provider tool-call indices in unified stream types and route interleaved tool deltas by index - move tool-call buffering/finalization into the shared accumulator and remove OpenAI-specific orphan/prelude filtering - update stream processor and response aggregators to consume accumulator outcomes for early detection and param streaming - ignore empty tool argument deltas and keep fallback handling for snapshot/tail-fill edge cases - add OpenAI stream regression fixtures for interleaved args, missing tool type, and trailing empty finish chunks - document that changes to stream processor or ai-adapters must run stream integration tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.