You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes the user table from the user page. It's a rather long table which is also available in the accounts admin tab. This should keep the user page a little cleaner and focused on the logged-in user's personal information.
Add a search box to the student groups admin panel
Discussion question: Do we want to also search the group description (currently, only the group name is searched)? If so, should there be a checkbox to disable that behavior?
Adds group membership buttons to students in the "add to group" popup.
When adding a member to a subgroup, shows members of the (immediate) parent group first.
Up for debate: Moves the "reload page" feature away from the user page (because it doesn't really have anything to do with the user)?
Up for debate: Shortens / hides / removes the "in Gruppen" section for admins, because it can get really long?
Expand group search matching with precedence matched groups --> mail/name -> matched group descriptions (or maybe with the first two flipped).
Discussion question: Do we want to also search the group description (currently, only the group name is searched)? If so, should there be a checkbox to disable that behavior?
Why not, i think this could be useful. imo no checkbox is needed, but the ordering precedence should be:
Up for debate: Moves the "reload page" feature away from the user page (because it doesn't really have anything to do with the user)?
This was put there initially to be at hand with one click. Now that we have hoverable user-badges, this can be handeled there?
Up for debate: Shortens / hides / removes the "in Gruppen" section for admins, because it can get really long?
I like the overview, but maybe we could show by default only the first 4? groups? and what i sometimes miss is the option to directly add groups in the table view... maybe we could add react-select?
Discussion question: Do we want to also search the group description (currently, only the group name is searched)? If so, should there be a checkbox to disable that behavior?
Why not, i think this could be useful. imo no checkbox is needed, but the ordering precedence should be:
match of mail/name
matched groups
matched group descriptions
I like it! I would change the precedence though. In most cases, the student names and group names will be disjoint, so it usually won't matter. But if I have a group called "Fabian", I would expect the student groups page to first show me that group, before showing me all groups containing some Fabian. This would also mean that searching for "fa" would return a class "22Fa" before all groups containing a Fabian, which feels more appropriate imo.
Discussion question: Do we want to also search the group description (currently, only the group name is searched)? If so, should there be a checkbox to disable that behavior?
Why not, i think this could be useful. imo no checkbox is needed, but the ordering precedence should be:
match of mail/name
matched groups
matched group descriptions
I like it! I would change the precedence though. In most cases, the student names and group names will be disjoint, so it usually won't matter. But if I have a group called "Fabian", I would expect the student groups page to first show me that group, before showing me all groups containing some Fabian. This would also mean that searching for "fa" would return a class "22Fa" before all groups containing a Fabian, which feels more appropriate imo.
I see your point, but for many groups (additional half classes and maybe in the future smaller work groups) i would like to have Fabian first for "Fa", but for "22" the 22Fa first and then "Fabian22.Nachname@edu...".
So maybe
match "startsWith" mail/name/groups
match groups (i dont bother to flip with mail/name here)
match of mail/name
matched group descriptions
what do you think of this?
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #220.