Skip to content

Conversation

@SilasBerger
Copy link
Contributor

@SilasBerger SilasBerger commented Sep 2, 2025

  • Removes the user table from the user page. It's a rather long table which is also available in the accounts admin tab. This should keep the user page a little cleaner and focused on the logged-in user's personal information.
  • Add a search box to the student groups admin panel
    • Discussion question: Do we want to also search the group description (currently, only the group name is searched)? If so, should there be a checkbox to disable that behavior?
  • Adds group membership buttons to students in the "add to group" popup.
  • When adding a member to a subgroup, shows members of the (immediate) parent group first.
  • Up for debate: Moves the "reload page" feature away from the user page (because it doesn't really have anything to do with the user)?
  • Up for debate: Shortens / hides / removes the "in Gruppen" section for admins, because it can get really long?
  • Expand group search matching with precedence matched groups --> mail/name -> matched group descriptions (or maybe with the first two flipped).

Closes #220.

@netlify
Copy link

netlify bot commented Sep 2, 2025

Deploy Preview for teaching-dev ready!

Name Link
🔨 Latest commit 53ffb34
🔍 Latest deploy log https://app.netlify.com/projects/teaching-dev/deploys/68c90d85deff7000081cf2b3
😎 Deploy Preview https://deploy-preview-233--teaching-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@lebalz
Copy link
Contributor

lebalz commented Sep 3, 2025

Discussion question: Do we want to also search the group description (currently, only the group name is searched)? If so, should there be a checkbox to disable that behavior?
Why not, i think this could be useful. imo no checkbox is needed, but the ordering precedence should be:

  1. match of mail/name
  2. matched groups
  3. matched group descriptions

@lebalz
Copy link
Contributor

lebalz commented Sep 3, 2025

Up for debate: Moves the "reload page" feature away from the user page (because it doesn't really have anything to do with the user)?
This was put there initially to be at hand with one click. Now that we have hoverable user-badges, this can be handeled there?

@lebalz
Copy link
Contributor

lebalz commented Sep 3, 2025

Up for debate: Shortens / hides / removes the "in Gruppen" section for admins, because it can get really long?
I like the overview, but maybe we could show by default only the first 4? groups? and what i sometimes miss is the option to directly add groups in the table view... maybe we could add react-select?

@SilasBerger
Copy link
Contributor Author

Discussion question: Do we want to also search the group description (currently, only the group name is searched)? If so, should there be a checkbox to disable that behavior?
Why not, i think this could be useful. imo no checkbox is needed, but the ordering precedence should be:

  1. match of mail/name
  2. matched groups
  3. matched group descriptions

I like it! I would change the precedence though. In most cases, the student names and group names will be disjoint, so it usually won't matter. But if I have a group called "Fabian", I would expect the student groups page to first show me that group, before showing me all groups containing some Fabian. This would also mean that searching for "fa" would return a class "22Fa" before all groups containing a Fabian, which feels more appropriate imo.

@lebalz
Copy link
Contributor

lebalz commented Sep 16, 2025

Discussion question: Do we want to also search the group description (currently, only the group name is searched)? If so, should there be a checkbox to disable that behavior?
Why not, i think this could be useful. imo no checkbox is needed, but the ordering precedence should be:

  1. match of mail/name
  2. matched groups
  3. matched group descriptions

I like it! I would change the precedence though. In most cases, the student names and group names will be disjoint, so it usually won't matter. But if I have a group called "Fabian", I would expect the student groups page to first show me that group, before showing me all groups containing some Fabian. This would also mean that searching for "fa" would return a class "22Fa" before all groups containing a Fabian, which feels more appropriate imo.

I see your point, but for many groups (additional half classes and maybe in the future smaller work groups) i would like to have Fabian first for "Fa", but for "22" the 22Fa first and then "Fabian22.Nachname@edu...".
So maybe

  1. match "startsWith" mail/name/groups
  2. match groups (i dont bother to flip with mail/name here)
  3. match of mail/name
  4. matched group descriptions
    what do you think of this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rework group admin section

3 participants