Feature/starling monkey upgrade #61
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove generated files
compiler working in docker image
fixed eslint
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the StarlingMonkey dependency while transitioning several JavaScript entry points to TypeScript and updating build, test, and configuration files accordingly.
- Upgraded the StarlingMonkey submodule and updated associated CMake configuration.
- Migrated several source files and entry points from JavaScript to TypeScript with corresponding ESLint and Jest configuration changes.
- Updated Docker, package, and compiler scripts to reflect new versioning and dependency adjustments.
Reviewed Changes
Copilot reviewed 147 out of 147 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| runtime/fastedge/host-api/host_api.cmake | Sets up host API configuration and paths for the upgraded StarlingMonkey integration. |
| runtime/fastedge/host-api/fastedge_host_api.cpp | Introduces helper functions to handle environment and secret variables via new bindings. |
| runtime/fastedge/host-api/deps/fastedge/*.wit | Adds/imports Wit interfaces for dictionary and secret functionality. |
| runtime/fastedge/builtins/fastedge.cpp | Updates include directive to reference the new header location. |
| package.json | Modifies build scripts and dependency versions to support TypeScript and new build processes. |
| jsconfig.json, jest.config.mjs | Removes obsolete configuration files now replaced by updated counterparts. |
| integration-tests/fastedge-build.test.js | Adjusts expected error messages and removes a test case related to missing TypeScript installation. |
| esbuild/* | Changes entry point source files from JavaScript to TypeScript and updates external dependency settings. |
| config/jest/jest.config.js & ESLint configs | Updates configuration for TypeScript support and improved module resolution. |
| compiler/* and Dockerfile | Upgrades image versions and dependencies to align with the new compiler and runtime environment changes. |
| @@ -0,0 +1,20 @@ | |||
| interface secret { | |||
| /// Get the secret associated with the specified `key` efective at current timestamp. | |||
There was a problem hiding this comment.
There is a spelling error: 'efective' should be corrected to 'effective'.
Suggested change
| /// Get the secret associated with the specified `key` efective at current timestamp. | |
| /// Get the secret associated with the specified `key` effective at current timestamp. |
Copilot uses AI. Check for mistakes.
typescript exists now from fastedge-sdk-js typescript exists now from fastedge-sdk-js
godronus
force-pushed
the
feature/starling-monkey-upgrade
branch
from
3921006 to
bde0be8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.