Skip to content

Conversation

@jamesbraza
Copy link
Collaborator

@jamesbraza jamesbraza commented Dec 9, 2025

Sister PR to Future-House/aviary#316


Note

Upgrade vcrpy to v8 and update tests to use httpcore stubs with a new async handler, adding drop_unused_requests to VCR config.

  • Dependencies:
    • Bump vcrpy to >=8 in pyproject.toml and packages/paper-qa-nemotron/pyproject.toml; update uv.lock (version 8.1.0).
  • Tests:
    • Switch imports from vcr.stubs.httpx_stubs to vcr.stubs.httpcore_stubs in tests/conftest.py and packages/paper-qa-nemotron/tests/conftest.py.
    • Replace async VCR patch from _async_vcr_send to _vcr_handle_async_request and assign to vcr.stubs.httpcore_stubs._vcr_handle_async_request.
    • Add "drop_unused_requests": True to vcr_config.

Written by Cursor Bugbot for commit 186be4d. Configure here.

@jamesbraza jamesbraza self-assigned this Dec 9, 2025
Copilot AI review requested due to automatic review settings December 9, 2025 00:32
@jamesbraza jamesbraza added the bug Something isn't working label Dec 9, 2025
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Dec 9, 2025
@dosubot
Copy link

dosubot bot commented Dec 9, 2025

Related Documentation

Checked 1 published document(s) in 1 knowledge base(s). No updates required.

How did I do? Any feedback?  Join Discord

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR upgrades the vcrpy dependency from version 6/7 to version 8, updating the codebase to use the new httpcore_stubs module instead of the deprecated httpx_stubs. This change aligns with vcrpy v8's internal API changes and enables the drop_unused_requests feature.

  • Updated vcrpy dependency specification from >=6 to >=8 across all package configurations
  • Migrated from vcr.stubs.httpx_stubs to vcr.stubs.httpcore_stubs module
  • Updated monkey-patching logic to use _vcr_handle_async_request instead of _async_vcr_send with updated function signatures
  • Enabled drop_unused_requests: True in VCR configuration for both test suites

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
uv.lock Updates vcrpy from v7.0.0 to v8.1.0, removing urllib3 and yarl dependencies that are no longer needed
pyproject.toml Bumps vcrpy requirement from >=6 to >=8 with updated comment explaining the pin reason
packages/paper-qa-nemotron/pyproject.toml Bumps vcrpy requirement from >=6 to >=8 with updated comment explaining the pin reason
tests/conftest.py Migrates to httpcore_stubs, adds drop_unused_requests config, and updates async request handler function
packages/paper-qa-nemotron/tests/conftest.py Migrates to httpcore_stubs, adds drop_unused_requests config, and updates async request handler function

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 9, 2025
@jamesbraza jamesbraza merged commit 0e8a479 into main Dec 9, 2025
12 of 14 checks passed
@jamesbraza jamesbraza deleted the newer-vcrpy branch December 9, 2025 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants