-
Notifications
You must be signed in to change notification settings - Fork 806
Pulling in vcrpy v8 for httpcore stubs
#1228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR upgrades the vcrpy dependency from version 6/7 to version 8, updating the codebase to use the new httpcore_stubs module instead of the deprecated httpx_stubs. This change aligns with vcrpy v8's internal API changes and enables the drop_unused_requests feature.
- Updated vcrpy dependency specification from
>=6to>=8across all package configurations - Migrated from
vcr.stubs.httpx_stubstovcr.stubs.httpcore_stubsmodule - Updated monkey-patching logic to use
_vcr_handle_async_requestinstead of_async_vcr_sendwith updated function signatures - Enabled
drop_unused_requests: Truein VCR configuration for both test suites
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| uv.lock | Updates vcrpy from v7.0.0 to v8.1.0, removing urllib3 and yarl dependencies that are no longer needed |
| pyproject.toml | Bumps vcrpy requirement from >=6 to >=8 with updated comment explaining the pin reason |
| packages/paper-qa-nemotron/pyproject.toml | Bumps vcrpy requirement from >=6 to >=8 with updated comment explaining the pin reason |
| tests/conftest.py | Migrates to httpcore_stubs, adds drop_unused_requests config, and updates async request handler function |
| packages/paper-qa-nemotron/tests/conftest.py | Migrates to httpcore_stubs, adds drop_unused_requests config, and updates async request handler function |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
186be4d to
31130cc
Compare
94bd952 to
07f83c1
Compare
Sister PR to Future-House/aviary#316
Note
Upgrade vcrpy to v8 and update tests to use httpcore stubs with a new async handler, adding drop_unused_requests to VCR config.
vcrpyto>=8inpyproject.tomlandpackages/paper-qa-nemotron/pyproject.toml; updateuv.lock(version8.1.0).vcr.stubs.httpx_stubstovcr.stubs.httpcore_stubsintests/conftest.pyandpackages/paper-qa-nemotron/tests/conftest.py._async_vcr_sendto_vcr_handle_async_requestand assign tovcr.stubs.httpcore_stubs._vcr_handle_async_request."drop_unused_requests": Truetovcr_config.Written by Cursor Bugbot for commit 186be4d. Configure here.