Skip to content

openAccessPdf to should map to pdf_url #1221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sidnarayanan merged 4 commits into from
Nov 26, 2025
+9 −3
Merged

openAccessPdf to should map to pdf_url #1221

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
aa3061f
openAccessPdf to should map to pdf_url
sidnarayanan Nov 26, 2025
2a04248
add pdf_url description
sidnarayanan Nov 26, 2025
49a28f8
update pdf_url in DocDetails
sidnarayanan Nov 26, 2025
76537be
set both url and pdf_url
sidnarayanan Nov 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/paperqa/clients/semantic_scholar.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,8 @@
"volume": {"journal"},
"pages": {"journal"},
"journal": {"journal"},
"url": {"url", "openAccessPdf"},
"url": {"url"},
"pdf_url": {"openAccessPdf"},
"bibtex": {"citationStyles"},
"doi_url": {"url"},
"other": {"isOpenAccess", "influentialCitationCount", "publicationTypes", "venue"},
Expand Down Expand Up @@ -189,6 +190,8 @@ async def parse_s2_to_doc_details(

journal_data = paper_data.get("journal") or {}

maybe_pdf_url = (paper_data.get("openAccessPdf") or {}).get("url")

doc_details = DocDetails(
key=None if not bibtex else bibtex.split("{")[1].split(",")[0],
bibtex_type="article", # s2 should be basically all articles
Expand All @@ -199,7 +202,8 @@ async def parse_s2_to_doc_details(
volume=journal_data.get("volume"),
pages=journal_data.get("pages"),
journal=journal_data.get("name"),
url=(paper_data.get("openAccessPdf") or {}).get("url"),
url=maybe_pdf_url,
pdf_url=maybe_pdf_url,
title=paper_data.get("title"),
citation_count=paper_data.get("citationCount"),
doi=doi,
Expand Down
4 changes: 3 additions & 1 deletion src/paperqa/types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -783,7 +783,9 @@ class DocDetails(Doc):
" that could be preprint). None means unknown/unset."
),
)
pdf_url: str | None = None
pdf_url: str | None = Field(
default=None, description="URL to the PDF of the paper, if known."
)
other: dict[str, Any] = Field(
default_factory=dict,
description="Other metadata besides the above standardized fields.",
Expand Down
Loading