Concurrency limits for Nemotron PDF reader #1220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesbraza
requested review from
maykcaldas,
mskarlin,
nadolskit,
sidnarayanan,
sremo and
whitead
dosubot
bot
added
the
size:S
|
Related Documentation Checked 1 published document(s) in 1 knowledge base(s). No updates required. How did I do? Any feedback? |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds an optional concurrency parameter to the Nemotron PDF reader to control memory usage during page processing. Since all pages are currently processed concurrently, this can cause memory bursts. The new parameter allows users to limit concurrency on a page-by-page basis.
- Added
concurrencyparameter toparse_pdf_to_pagesfunction acceptingint | asyncio.Semaphore | None - Implemented conditional logic to use
gather_with_concurrencywhen concurrency limit is specified, otherwise useasyncio.gather - Enhanced
NemotronLengthErrorin the Nvidia API path to include response details for debugging
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| packages/paper-qa-nemotron/src/paperqa_nemotron/reader.py | Added optional concurrency parameter to control concurrent page processing and prevent memory bursts |
| packages/paper-qa-nemotron/src/paperqa_nemotron/api.py | Enhanced NemotronLengthError exception to include response choice data for caller debugging |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
whitead
approved these changes
Nov 22, 2025
jamesbraza
force-pushed
the
nemotron-concurrency
branch
from
0d7e7c5 to
9b6732a
Compare
jamesbraza
changed the title
jamesbraza
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since all pages are concurrently read, this is a bit bursty in memory usage. This PR adds an optional concurrency limit to limit the burst on a page-basis.