Add support for using Java or Restify HTTP clients #20
Conversation
| @@ -26,25 +34,62 @@ | |||
| * @author Daniel DeGroff | |||
| */ | |||
| public class JavaHTTPLoadTestWorker extends BaseWorker { | |||
| private final HttpClient javaHTTPClient = HttpClient.newBuilder() | |||
There was a problem hiding this comment.
Better to do this initialization in a constructor? I'm not a fan of having anything that feels like logic outside of a method, but that's kind of just personal preference.
There was a problem hiding this comment.
Sure, I can move it. We have this same pattern in prime-mvc, so I just copied it, but I can move it to the constructor.
| } | ||
|
|
||
| if (response.exception != null) { | ||
| System.out.println(response.exception.getClass().getSimpleName() + " [" + response.exception.getMessage() + "]"); |
There was a problem hiding this comment.
Any reason we're using stdout directly instead of a logging framework?
There was a problem hiding this comment.
No particular reason. This is essentially a CLI tool, and most of the output is all using stdout for reporting, etc.
We could consider moving all of the stdout to a logger config.
In practice, this is really just for debugging - looking for SocketExceptions based upon some server configuration I was testing. I could probably just delete these lines.
Summary
Doing some work with loading testing in
java-http. This adds support to allow the test definition to swap between the Java REST client and ours (Restify) easily.This is useful to see the difference in performance.
Related