feat: fee algo performance metrics #215
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
segfault-magnet
requested review from
digorithm,
hal3e,
MujkicA and
Salka1988
as code owners
segfault-magnet
commented
Mar 20, 2025
| @@ -1,267 +1,5 @@ | |||
| use std::time::Duration; | |||
There was a problem hiding this comment.
Mostly moved into a separate file.
segfault-magnet
commented
Mar 20, 2025
| @@ -0,0 +1,200 @@ | |||
| use std::num::NonZeroU64; | |||
There was a problem hiding this comment.
Nothing much changed, mostly just moved from the parent mod.
AurelienFT
approved these changes
Apr 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: #214
Before updating the price algo I decided to update the simulator so we can get actual numbers of saved eth against which to compare the new algo.
You can now configure how big a bundle is (eg 3600 fuel blocks), how many blobs that is (eg 3 eth blob) and how long does it take for one eth tx to finalize (eg 5 mins). When ran on the last month of eth pricing data:
This is good enough for now, but ideally we'd want a tool that can connect to the prod db and give insight into expected vs realized fees, as these can differ depending on time to inclusion.