feat: changed MailFinderService to load all TemplateTypes at once - #86
Merged
Conversation
Member
Author
tinect
force-pushed
the
feat/loadTemplateTypeAtOnce
branch
5 times, most recently
from
December 23, 2025 22:42
5716d67 to
93c6866
Compare
tinect
marked this pull request as ready for review
December 23, 2025 23:22
tinect
force-pushed
the
feat/loadTemplateTypeAtOnce
branch
4 times, most recently
from
December 23, 2025 23:50
9231d15 to
55db7e5
Compare
tinect
force-pushed
the
feat/loadTemplateTypeAtOnce
branch
from
December 24, 2025 13:14
55db7e5 to
395ee71
Compare
tinect
force-pushed
the
feat/loadTemplateTypeAtOnce
branch
from
December 24, 2025 13:49
395ee71 to
6ee9afa
Compare
Member
Author
|
@Schrank would this work for you? |
|
My colleague tested it and it works as expected <3 Feel free to merge it! |
|
And thank you very much for the work <3 |
Member
Author
|
@shyim ? :-) |
BREAKING CHANGE: MailFinderServiceInterface has changed structure
schneider-felix
requested changes
Jan 19, 2026
Member
|
Well no you'll also need to add the |
Co-authored-by: Felix Schneider <69912882+schneider-felix@users.noreply.github.com>
tinect
force-pushed
the
feat/loadTemplateTypeAtOnce
branch
from
January 19, 2026 15:51
9cedd5d to
f611089
Compare
schneider-felix
approved these changes
Jan 20, 2026
tinect
force-pushed
the
feat/loadTemplateTypeAtOnce
branch
from
January 21, 2026 07:03
6cebe8d to
d7db087
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Used Struct to add possibility to extend it - is it worth it?noloaderalso before