fix: restore Shopware Services & extension dashboard slots - #7
Open
roboshyim wants to merge 3 commits into
Open
Conversation
Replacing sw-dashboard-index dropped core injection points that Services and other extensions rely on. Render the same hooks as core: - sw-settings-services-dashboard-banner - sw-extension-component-section sw-dashboard__before-content - sw-extension-component-section sw-dashboard__after-content around the modular widget grid.
Contributor
Author
Browser review (dockware SW 6.7.2.2)Installed this PR branch, rebuilt administration, verified dashboard. DOM order under
Visual: Banner above the widget board with clean spacing; no overlap/cutoff; edit mode still fine. Looks good to merge from a UI perspective. Screenshots: |
Contributor
Author
Browser review (dockware SW 6.7.2.2)Installed this branch, rebuilt admin, logged in as admin. Verified
ScreenshotsDashboard top (Services banner + widgets): Edit mode (banner remains above grid toolbar): Looks good from a UI standpoint. |
Add config.xml toggles (default on): - showServicesBanner - showExtensionSections Dashboard page loads FroshAdminDashboard.config via systemConfigApiService and v-if's the restored core injection points so merchants can opt out.
Contributor
Author
Follow-up: plugin config to disable injectionsAdded under Settings → System → Plugins → Modular Admin Dashboard:
Defaults keep the restored core behaviour; turn off either switch for a board-only dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replacing the core
sw-dashboard-indexpage removed the injection points Shopware Services (and other extensions) use on the dashboard.Core dashboard includes
From
sw-dashboard-index.html.twig:<sw-settings-services-dashboard-banner />— Shopware Services promo/status banner<sw-extension-component-section position-identifier="sw-dashboard__before-content" /><sw-extension-component-section position-identifier="sw-dashboard__after-content" />Fix
frosh-dashboard-indexnow renders those same components around the widget grid, using the same position identifiers so existing extensions keep working without changes.Test plan
core.hide-services-dashboard-banner)sw-dashboard__before-content/after-contentstill appear