chore: publish MonitoredItemMap to allow implementing OnSubscriptionNotificationCore in client crates #168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
We warn on public methods missing docs, so you'll need to write a simple docstring for the This is an oversight. Thanks for the PR! |
elrafoon
force-pushed
the
pub-MonitoredItemMap
branch
from
c7097ae to
5fbc809
Compare
Author
|
I finally got back to this, and documented |
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #168 +/- ##
=========================================
Coverage ? 82.87%
=========================================
Files ? 628
Lines ? 321873
Branches ? 321873
=========================================
Hits ? 266754
Misses ? 53449
Partials ? 1670 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…otificationCore in client crates
einarmo
force-pushed
the
pub-MonitoredItemMap
branch
from
5fbc809 to
f50e6b4
Compare
Contributor
|
Looks like you need to format the code, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
thank you for this very nice crate!
I just bumped upon a minor problem - I need to batch the updates from OPC/UA server and push Vec of them into message queue.
If I understand it correctly, it's required to implement
trait OnSubscriptionNotificationCore.That's straightforward, but
struct MonitoredItemMapreferenced infn on_subscription_notificationis not public,so it's impossible to implement the trait.
So please accept this tiny PR.