Skip to content

Resolve VCSWP-23775 #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 11, 2025
Merged

Resolve VCSWP-23775 #59

merged 6 commits into from
Feb 11, 2025

Conversation

amahadaya
Copy link
Contributor

Closes VCSWP-23775

@edgeston edgeston self-requested a review February 5, 2025 21:50
Copy link
Contributor

@edgeston edgeston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the MR looks good to me. I have a couple of questions about some values.
Also wanted to check if the spaces in the functions were intentional

@amahadaya amahadaya merged commit 4abe8f5 into master Feb 11, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants