[Fix] Tooltip Color Scope#1964
Merged
Merged
Conversation
Contributor
|
Do we globally style all tooltips? I recall foundry had data-tooltip-class (which can be defined at any parent, even the outermost div), but if we style all tooltips regardless of source then this should be fine. |
Contributor
Author
|
Ah, yeah that's a lot better. Removed the global styling and now specifically adding |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added DH style to tooltips to fix the coloring of ArmorManagement and ResourceManagement tooltip.
The new scoped color variables weren't hitting as it didn't match any of the rules.
Prev
Changed
Not 100% if it's right to tack it on in the
setStylemethod, but it doesn't seem to cause any trouble in other tooltips from what I've noticed.