[Fix] Base Attack Context Menu#1961
Merged
Merged
Conversation
Contributor
|
If the options are the same everywhere, protected method or actor folder helpers? The copy paste is fine now but if extended/fixed it'd be nice to avoid a desync. |
Contributor
Author
|
Hm, yah they are strict al-dente copy pastas. Hm hm.. |
Contributor
Author
|
So I can easily just define a static method in the parent that all 3 of 'em use: Dunno if I can really make it protected though, since it has to be statically available for |
Contributor
|
That should be fine. |
CarlosFdez
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1924
Fixes #1669
I only added in attack/damage/show-message as these are not things to edit or delete. The main benefit is the

Damageoption being available now.Minor thing I also spotted - fixed so that adversaries do not display

Object Objectif the current Attack Damage is invalidPrevious
After
