Skip to content

[UI/UX] Remove item type line from domain cards#1903

Open
CarlosFdez wants to merge 3 commits into
mainfrom
adjust-domain-card-size
Open

[UI/UX] Remove item type line from domain cards#1903
CarlosFdez wants to merge 3 commits into
mainfrom
adjust-domain-card-size

Conversation

@CarlosFdez
Copy link
Copy Markdown
Contributor

@CarlosFdez CarlosFdez commented May 19, 2026

Removes the "Domain Card" label from the item, reducing the total height. I was originally gonna reduce the image height, but then I found out I mathed out the aspect ratios from the book wrong, we are actually correct.

We can reject this or redirect the change if we think this will make it harder on newbies.

image

@moliloo
Copy link
Copy Markdown
Contributor

moliloo commented May 23, 2026

The idea to have the type write there is because its a pattern followed in the cards items to have a label that clearly say what is that card.
If you think its not necessary we can remove, just explaining to you whats the idea to have this label there

image

@moliloo moliloo added the enhancement New feature or request label May 23, 2026
@CarlosFdez
Copy link
Copy Markdown
Contributor Author

CarlosFdez commented May 23, 2026

Makes sense, though the actual cards don't observe that pattern. It seems like in the book, Spell/Ability play that role.

image image image

We could do something like Grimoire Domain Card if we should dummy proof more than the in person game (nothing wrong with that), but we might need to move Domain + Level to be entirely to the header for that to look good, and that requires some card design tweaks.

@CarlosFdez CarlosFdez changed the title Remove item type line from domain cards [UI/UX] Remove item type line from domain cards May 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants