[Feature] ActionConfig - Granular Outcomes#1880
Conversation
| } | ||
|
|
||
| static addDamage(_event) { | ||
| static addDamage(_event, button) { |
There was a problem hiding this comment.
This is a general thing in the codebase, but do you mind if we rename actions like these to #onAddDamage? It differentiates from methods invoked to do things, and its also the convention used by the core foundry codebase.
There was a problem hiding this comment.
I suppose we could, although it does feel like becoming the villain of my own story.
In the case of Foundry, I detest the use of #. It's always the reason we end up needing to copy some 5 extra methods when we want to override just 1, as it's not possible to reference the private methods from outside.
In our case it's probably less of an issue though as our classes and dialogs aren't intended to be overwritten.
There was a problem hiding this comment.
the important thing is starting with on. If using # makes you uncomfortable we can avoid it. Let me know.
The main benefit of using # is being able to make changes without being concerned about something being part of a public interface. I am in agreement when functionality can't be replicated.
CarlosFdez
force-pushed
the
feature/granular-action-outcomes
branch
from
87a7a75 to
1af377b
Compare
2 participants
No description provided.