[Feature] Class Custom Levelup Options#1816
Draft
WBHarry wants to merge 4 commits into
Draft
Conversation
* Moved default hope/fear/advantage/disadvantage under system/rules/roll and changed them to be dice indexs * . * . * .
Contributor
|
If possible I'd like to keep the API the same, and use faces instead of an index. What's the reason for the index? EDIT: If its done in code, putting die sizes in an array and then doing |
Contributor
Author
|
The reason for an index is that it's consistent and workable that an active effect does |
Contributor
|
Is it intended for an AE to do the bump here? It looked like bumps are in code, and those are easy enough to handle. |
Contributor
Author
|
It's intended for AE's, but also with this PR intended to be able to raise/lower by 1 to support levelup options. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
diceso that the index of used dice can be upgraded via levelup options. Primarily intended for the Combo Die, but it could be used as an option to improve your default advantage die or such.system.rules.dice