Skip to content

[Feature] Class Custom Levelup Options#1816

Draft
WBHarry wants to merge 4 commits into
mainfrom
feature/class-custom-levelup-options
Draft

[Feature] Class Custom Levelup Options#1816
WBHarry wants to merge 4 commits into
mainfrom
feature/class-custom-levelup-options

Conversation

@WBHarry
Copy link
Copy Markdown
Contributor

@WBHarry WBHarry commented Apr 19, 2026

  • Added in so that a class can declare custom levelup options on the different tiers.
  • Added a levelup option for dice so that the index of used dice can be upgraded via levelup options. Primarily intended for the Combo Die, but it could be used as an option to improve your default advantage die or such.
  • Moved all Dice rules in under system.rules.dice

@WBHarry WBHarry marked this pull request as ready for review April 20, 2026 18:55
WBHarry and others added 3 commits April 21, 2026 16:13
* Moved default hope/fear/advantage/disadvantage under system/rules/roll and changed them to be dice indexs

* .

* .

* .
@CarlosFdez
Copy link
Copy Markdown
Contributor

CarlosFdez commented Apr 29, 2026

If possible I'd like to keep the API the same, and use faces instead of an index. What's the reason for the index?

EDIT: If its done in code, putting die sizes in an array and then doing Math.min(DIE_SIZES.length - 1, DIE_SIZES.indexOf(blah) + 1) should be sufficient. But if its an AE it might be more difficult.

@WBHarry
Copy link
Copy Markdown
Contributor Author

WBHarry commented Apr 29, 2026

The reason for an index is that it's consistent and workable that an active effect does +1 to get to the next dice size - rather than it being variable. (d10 -> d12 = 2, d12 -> d20 ) = 8)

@CarlosFdez
Copy link
Copy Markdown
Contributor

Is it intended for an AE to do the bump here? It looked like bumps are in code, and those are easy enough to handle.

@WBHarry
Copy link
Copy Markdown
Contributor Author

WBHarry commented Apr 29, 2026

It's intended for AE's, but also with this PR intended to be able to raise/lower by 1 to support levelup options.

@WBHarry WBHarry marked this pull request as draft May 25, 2026 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants