Skip to content

SVG and logo fix#684

Merged
nichollsh merged 17 commits into
mainfrom
ks/svg
May 28, 2026
Merged

SVG and logo fix#684
nichollsh merged 17 commits into
mainfrom
ks/svg

Conversation

@stuitje
Copy link
Copy Markdown
Contributor

@stuitje stuitje commented May 28, 2026

Description

This PR:

  1. Fixes the proteus schematic SVGs, as Safari still had issues with the old (cropped) ones. The SVGs are now remade with the 'orbit' and 'sun' as images, instead of parts of circular shapes, so that the diagram automatically has the size of the actual content, and does not include any invisible regions. This avoids a crop, which led to issues in Safari (and how it deals with ForeignObject, which draw.io uses for text). + adds H in CHNOS

  2. Replaces some logos with updated ones and adds dark mode logos to improve the look of the funding page in dark mode. Some comments about this below.

Some funders have explicit logo policies on their website. A good example is SNSF, which states we are obliged to place their logo on our website (which we do) but also notes that the SNSF logo may not be adapted and has to be used in its original form. It adds a large number of downloadable logos for website, presentations, and more, each in a certain language with a dark and light version (which is great!).

However, other funders do not, or do, but do not provide us with a dark-mode version. Here is an overview:

  • Branco Weiss: no clear policy as far as I can fnd, no downloadable logo, no dark mode. I recoloured the black text to white in the current dark mode version. I could also contact them.
  • Simons: both versions obtained via: https://www.simonsfoundation.org/about/simons-foundation-brand-guidelines/. Should be good.
  • SNSF: as explained above, all good.
  • RUG: white logo downloaded from website
  • eScience: no logo policy as far as I can fnd, the dark mode version I added I got from @egpbos
  • Oxford: there is a clear brand policy, which forbids the use of modified logos but only provides a download link to oxford staff. I am now, for both dark and light mode, using the low-quality version on their brand policy page, but since this has been cropped it is technically still altered.
  • ERC: there is a logo policy here, but no dark mode version provided. For both dark and white mode I used the light mode version, which is not ideal.

Validation of changes

I built the website locally on firefox, safari and chrome.

Checklist

  • I have followed the contributing guidelines
  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • My changes generate no new warnings or errors
  • I have checked that the tests still pass on my computer
  • I have updated the docs, as appropriate
  • I have added tests for these changes, as appropriate
  • I have checked that all dependencies have been updated, as required

Relevant people

@nichollsh

@egpbos : perhaps you know more about how serious we should take all this :)

@stuitje stuitje self-assigned this May 28, 2026
Copilot AI review requested due to automatic review settings May 28, 2026 11:01
@stuitje stuitje added the Docs Update documentation webpage label May 28, 2026
@stuitje stuitje requested a review from nichollsh May 28, 2026 11:03
@stuitje stuitje marked this pull request as ready for review May 28, 2026 11:03
@stuitje stuitje requested a review from a team as a code owner May 28, 2026 11:03
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copy link
Copy Markdown
Member

@nichollsh nichollsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for this. I believe that it will fix the rendering issues on Firefox/Safari and also brings the font self-consistently inline with our new style guide.

@nichollsh nichollsh merged commit 534eb28 into main May 28, 2026
6 of 8 checks passed
@nichollsh nichollsh deleted the ks/svg branch May 28, 2026 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Docs Update documentation webpage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants