fix(reactjs-todo-davinci): fix social login continuation#89
Merged
Conversation
ancheetah
force-pushed
the
fix-social
branch
2 times, most recently
from
931af83 to
15e00f7
Compare
ryanbas21
approved these changes
Feb 2, 2026
cerebrl
approved these changes
Feb 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the social login button is clicked it is calling the onSubmitHandler for the form which calls next(). While simultaneously executing the onClick handler for social login. This causes the flow to resume prematurely before the user has completed social login. Changing the button type to button prevents this and fixes the redirection back to the react application at the correct point in the DaVInci flow.