Conversation
javascript/react-journey/README.md
Outdated
| ## Requirements | ||
|
|
||
| 1. An instance of Ping's Access Manager (AM), either within a Ping's Advanced Identity Cloud tenant, your own private installation or locally installed on your computer | ||
| 2. Node >= 14.2.0 (recommended: install via [official package installer](https://nodejs.org/en/)) |
There was a problem hiding this comment.
maybe we should update this to a newer node, we dont test this far back so maybe 18? 18 is still pretty old
There was a problem hiding this comment.
updated to 18.12.0
javascript/react-journey/client/components/journey/identity-provider.js
Outdated
Show resolved
Hide resolved
| */ | ||
|
|
||
| // TODO: Have we ported over HttpClient yet? | ||
| import { HttpClient } from '@forgerock/javascript-sdk'; |
There was a problem hiding this comment.
We haven't but i think we could probably remove this and use a plain fetch
ancheetah
force-pushed
the
SDKS-4047-react-journey
branch
2 times, most recently
from
cc7c400 to
3962b82
Compare
ancheetah
force-pushed
the
SDKS-4047-react-journey
branch
4 times, most recently
from
23683ad to
b09f40e
Compare
ancheetah
force-pushed
the
SDKS-4047-react-journey
branch
from
b09f40e to
315978c
Compare
|
Please review "SDK Integration" comments and OIDC Context |
cerebrl
left a comment
cerebrl
left a comment
There was a problem hiding this comment.
This looks good. I have one non-blocking that we can address in a follow up PR.
| * @function useOidcClient - A custom hook to access the OIDC client from React Context | ||
| * @returns - An OIDC client if it exists otherwise an error | ||
| */ | ||
| export function useOidcClient() { |
There was a problem hiding this comment.
It seems this module differs a bit from the global-state.js pattern. Can we make sure these are consistent in both file name and internal patterns?
See the screenshot attached.
Update Protect module in react-journey sample app
SDKS-4707: Migrate HttpClient to fetch
| * | ||
| * protect.context.js | ||
| * | ||
| * Copyright (c) 2026 Ping Identity Ping Identity Corporation. All rights reserved. |
There was a problem hiding this comment.
Hey just a heads up: I noticed "Ping Identity" is showing up twice in the copyright header of a few files.
There was a problem hiding this comment.
Good catch, I'll update these in my next pr. Thanks!
4 participants
Jira: https://pingidentity.atlassian.net/browse/SDKS-4047
TODO:
DO NOT MERGE: Pending release of journey client and oidc client. OIDC and Journey package dependencies need to be updated.