Conversation
Merge develop to feature branch
vahancouver
requested review from
george-bafaloukas-forgerock,
rodrigoareis and
spetrov
and removed request for
george-bafaloukas-forgerock
george-bafaloukas-forgerock
approved these changes
Jan 30, 2026
Contributor
george-bafaloukas-forgerock
left a comment
george-bafaloukas-forgerock
left a comment
There was a problem hiding this comment.
LGTM, some minor comments
DeviceProfile/DeviceProfileTests/DeviceProfileCollectorTests.swift
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SDKS-4678 [Ping SDK] [iOS] Investigate all excluded tests, fix and mark them included
Addressed all excluded tests. No more excluded tests as of now
I'm not super happy about our LocationManager, but maybe we can rewrite it as part of another ticket. the continuation logic is not 100%robust