Skip to content

SDKS-4205_Possible cause of FRAuth.ConfigError.invalidAccessGroup("XXX") & FRAuth.ConfigError.invalidSDKState#361

Open
george-bafaloukas-forgerock wants to merge 2 commits intodevelopfrom
SDKS-4205_KeychainService_extra_logs
Open

SDKS-4205_Possible cause of FRAuth.ConfigError.invalidAccessGroup("XXX") & FRAuth.ConfigError.invalidSDKState#361
george-bafaloukas-forgerock wants to merge 2 commits intodevelopfrom
SDKS-4205_KeychainService_extra_logs

Conversation

@george-bafaloukas-forgerock
Copy link
Contributor

JIRA Ticket

Please link jira ticket here, if applicable.
Possible cause of FRAuth.ConfigError.invalidAccessGroup("XXX") & FRAuth.ConfigError.invalidSDKState

Description

Adding extra logs and errors breakdown on the validateAccessGroup method

Definition of Done Checklist:

  • Coded to standards.
  • Ensure backward compatibility.
  • API reference docs is created or updated, if applicable.
  • Unit tests are written or updated.
  • Integration tests are written, if applicable.

Copy link
Contributor

@rodrigoareis rodrigoareis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good to me. Just two minor questions to be addressed.

case errSecAllocate:
return "Memory allocation failed"
default:
if #available(iOS 11.3, macOS 10.13.4, *) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this if?

Copy link
Contributor Author

@george-bafaloukas-forgerock george-bafaloukas-forgerock Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, fixed

Copy link
Contributor

@vahancouver vahancouver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@rodrigoareis rodrigoareis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do not merge Do not merge to develop (yet)

Development

Successfully merging this pull request may close these issues.

3 participants