Skip to content

Conversation

@goldenkirbi
Copy link

@goldenkirbi goldenkirbi commented Nov 13, 2023

Added VNCPasswordFile definition for Linux and VNCPasswordRegistryValue for Windows.

Windows definition currently covers registry locations used by RealVNC and TightVNC.

Definitions for Darwin currently not implemented.

Closes #587

@joachimmetz joachimmetz self-assigned this Nov 15, 2023
@codecov
Copy link

codecov bot commented Nov 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (36fb328) 88.03% compared to head (9c10067) 88.03%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #588   +/-   ##
=======================================
  Coverage   88.03%   88.03%           
=======================================
  Files           7        7           
  Lines         443      443           
=======================================
  Hits          390      390           
  Misses         53       53           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joachimmetz
Copy link
Member

@goldenkirbi is this ready for review? Looks like the YAML linter is flagging some issues

data/vnc.yaml
  9:7       error    wrong indentation: expected 4 but found 6  (indentation)
  26:28     error    trailing spaces  (trailing-spaces)
  [31](https://github.com/ForensicArtifacts/artifacts/actions/runs/6853173400/job/18692315988?pr=588#step:7:32):7      error    wrong indentation: expected 4 but found 6  (indentation)

@joachimmetz joachimmetz self-requested a review November 19, 2023 08:32
@joachimmetz
Copy link
Member

@goldenkirbi note this PR will be affected by #592

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add VNC password artifact

2 participants