Skip to content

Conversation

@Karneades
Copy link
Contributor

Add note for WSL because otherwise it can't be found. Filtered in GRR for "WSL", "Linux", "Subsystem", ... found nothing. At least a note for WSL must be there.

I was searching again for WSL, didn't find anything in the artifacts and then searched through the Github repo for WSL. Found my own contribution (haha). We already worte in the PR about if we should make a note about WSL in the artifact... today, I run into that again. Was already making a new one...

Also, inside GRR I looked first only for Windows artifacts, then switched to all. As I wrote in the PR #385 I would move that to Windows because I search there for the WSL part and not in the Unix part.

@codecov
Copy link

codecov bot commented Jun 25, 2021

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.92%. Comparing base (2723924) to head (d573c48).
⚠️ Report is 191 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #430   +/-   ##
=======================================
  Coverage   91.92%   91.92%           
=======================================
  Files           7        7           
  Lines         446      446           
=======================================
  Hits          410      410           
  Misses         36       36           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@joachimmetz
Copy link
Member

@Karneades thx for the suggested changes. Must have missed your comments on #385.

Could a WSL label help here? Though it does not look like GRR allows to filter on labels.

Adding WSL to supported_os might be more involved for GRR

@Karneades
Copy link
Contributor Author

I currently don't know how to best make it "foundable" in GRR and be enough generic for the repo. supported_os is incorrect for me because it's not an own OS. Add a label seems a good way.

@joachimmetz
Copy link
Member

@Karneades the definitions now support aliases (GRR not yet) but that might be a more suitable solution for the use case you describe.

@joachimmetz joachimmetz added the blocked Work cannot progress until another issue is resolved label Mar 20, 2022
@Karneades
Copy link
Contributor Author

timeout. closing.

@Karneades Karneades closed this Dec 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blocked Work cannot progress until another issue is resolved

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants