Skip to content

Remove .h files from compilation process #727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Remove .h files from compilation process #727

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e1a64ea
Remove .h files from compilation process
kant2002 Nov 21, 2024
055311e
Remove expectation of .h files
kant2002 Nov 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Cesium.Sdk.Tests/EvaluationTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ public class EvaluationTests(ITestOutputHelper testOutputHelper) : SdkTestBase(t
[InlineData("SimpleCoreLibraryWithHeader")]
public async Task Evaluation_EnableDefaultCompileItems(string projectName)
{
HashSet<string> expectedCompileItems = ["library.c", "library.h"];
HashSet<string> expectedCompileItems = ["library.c"];

var items = await ListItems(projectName, "Compile");

Expand Down
5 changes: 0 additions & 5 deletions Cesium.Sdk/Sdk/Sdk.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,6 @@
<ProduceReferenceAssembly>false</ProduceReferenceAssembly>
</PropertyGroup>

<ItemGroup Label="DefaultItems">
<!-- .c files are included by the Microsoft.NET.Sdk using DefaultLanguageSourceExtension, but .h ones are not -->
<Compile Include="**/*.h" Exclude="$(DefaultItemExcludes);$(DefaultExcludesInProjectFolder)" Condition="$(EnableDefaultCompileItems) == 'true'" />
</ItemGroup>

<ItemGroup Condition=" $(SkipCesiumCompilerInstallation) != 'true' ">
<PackageReference Include="$(CesiumCompilerPackageName)"
Version="$(CesiumCompilerPackageVersion)"
Expand Down
Loading