Solve cache tests failure and merge explain ambiguity handling - #2
Open
FolatheDuckofDuckingburg wants to merge 3 commits into
Open
Conversation
…uity handling 1. Fix `test_semantic_prune_removes_orphan_entries` test failure by using different content lengths for successive writes, preventing the filesystem stat fastpath from mis-matching cache hashes within the same nanosecond/mtime window. 2. Integrate explain ambiguity detection and exact node-ID bypass from origin/fix/explain-ambiguity-1969 to handle multiple tied nodes and accept exact node IDs. 3. Add regression tests in tests/test_explain_ambiguity.py and verify via uv/pre-commit. Co-authored-by: FolatheDuckofDuckingburg <268987568+FolatheDuckofDuckingburg@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1. Resolve flake8 F824 unused global variable warning for _stat_index_root in graphify/cache.py by removing it from the global declaration in _flush_stat_index(). 2. Fix `test_semantic_prune_removes_orphan_entries` test failure by using different content lengths for successive writes, preventing the filesystem stat fastpath from mis-matching cache hashes within the same nanosecond/mtime window. 3. Integrate explain ambiguity detection and exact node-ID bypass from origin/fix/explain-ambiguity-1969 to handle multiple tied nodes and accept exact node IDs. 4. Add regression tests in tests/test_explain_ambiguity.py and verify via uv/pre-commit. Co-authored-by: FolatheDuckofDuckingburg <268987568+FolatheDuckofDuckingburg@users.noreply.github.com>
…ckage installation 1. Resolve flake8 F824 unused global variable warning for _stat_index_root in graphify/cache.py by removing it from the global declaration in _flush_stat_index(). 2. Fix `test_semantic_prune_removes_orphan_entries` test failure by using different content lengths for successive writes, preventing the filesystem stat fastpath from mis-matching cache hashes within the same nanosecond/mtime window. 3. Integrate explain ambiguity detection and exact node-ID bypass from origin/fix/explain-ambiguity-1969 to handle multiple tied nodes and accept exact node IDs. 4. Add package installation step (`pip install .`) to `.github/workflows/python-app.yml` so that tests can successfully collect and run with all dependencies (such as networkx, numpy) installed. 5. Add regression tests in tests/test_explain_ambiguity.py and verify via uv/pre-commit. Co-authored-by: FolatheDuckofDuckingburg <268987568+FolatheDuckofDuckingburg@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a flaky test on the cache prune logic and merges ambiguity handling into the explain CLI command.
PR created automatically by Jules for task 2159019173269205490 started by @FolatheDuckofDuckingburg